refactor(linter): improve eslint/no-constant-condition#8845
Closed
shulaoda wants to merge 1 commit intooxc-project:mainfrom
Closed
refactor(linter): improve eslint/no-constant-condition#8845shulaoda wants to merge 1 commit intooxc-project:mainfrom
eslint/no-constant-condition#8845shulaoda wants to merge 1 commit intooxc-project:mainfrom
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #8845 will not alter performanceComparing Summary
|
Boshen
reviewed
Feb 3, 2025
Boshen
reviewed
Feb 6, 2025
Member
Boshen
left a comment
Boshen
left a comment
There was a problem hiding this comment.
Can you do a fix PR for the global reference problem (semantic + globals) to reduce the changes of this PR?
Sysix
pushed a commit
that referenced
this pull request
Feb 7, 2025
Can you do a fix PR for the global reference problem (semantic + `globals`) to reduce the changes of this PR? _Originally posted by @Boshen in #8845 (review)
shulaoda
force-pushed
the
refactor/no-constant-condition
branch
from
32d78c0 to
1d7e4f3
Compare
Contributor
|
closed by #10949 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've re-ported all the test cases for
eslint/no-constant-conditionand ensured they pass successfully. Additionally, I have aligned its options configuration witheslint.